Skip to content

feat: factory methods for Grants made public#36123

Merged
mergify[bot] merged 3 commits intomainfrom
otaviom/grant-factory-methods
Nov 20, 2025
Merged

feat: factory methods for Grants made public#36123
mergify[bot] merged 3 commits intomainfrom
otaviom/grant-factory-methods

Conversation

@otaviomacedo
Copy link
Contributor

@otaviomacedo otaviomacedo commented Nov 20, 2025

The <Resource>Grants._from<Resource>() methods were marked as internal while we experimented with the interface. Make them public.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 20, 2025 10:48
@github-actions github-actions bot added the p2 label Nov 20, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 20, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 20, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@pahud pahud mentioned this pull request Nov 20, 2025
Open
@otaviomacedo otaviomacedo added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 20, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 20, 2025 13:54

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 20, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 20, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f9a894f into main Nov 20, 2025
18 of 19 checks passed
@mergify mergify bot deleted the otaviom/grant-factory-methods branch November 20, 2025 15:02
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@otaviomacedo @mrgrain @aws-cdk-automation